File.from_stream does not load content into memory #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shnela
commented
Oct 27, 2022
| @@ -235,7 +235,7 @@ def test_get_html_from_bokeh(self): | |||
| result = get_html_content(p) | |||
|
|
|||
| # then | |||
| self.assertTrue(result.startswith('<!DOCTYPE html>\n<html lang="en">')) | |||
| self.assertTrue(result.lstrip().startswith('<!DOCTYPE html>\n<html lang="en">')) | |||
There was a problem hiding this comment.
Pibbyback fixing test which always fails on my local Ubuntu.
shnela
commented
Oct 28, 2022
| self, | ||
| path: Optional[str] = None, | ||
| content: Optional[bytes] = None, | ||
| extension: Optional[str] = None, |
There was a problem hiding this comment.
Yes, @Herudaio accepted removing extension from this init.
shnela
commented
Oct 28, 2022
shnela
commented
Oct 28, 2022
src/neptune/new/types/atoms/file.py
Outdated
|
|
||
| @staticmethod | ||
| def from_stream(stream: IOBase, seek: Optional[int] = 0, extension: Optional[str] = None) -> "File": | ||
| # TODO: docs (update) |
There was a problem hiding this comment.
We could inform user that from now on, he will be able to use file created with File.from_stream at most once.
shnela
commented
Oct 28, 2022
shnela
changed the title
shnela
force-pushed
the
jk/in-memory-stream
branch
2 times, most recently
from
d0554c1
to
b2d0002
Compare
Raalsky
reviewed
Nov 2, 2022
| @@ -0,0 +1,170 @@ | |||
| # | |||
There was a problem hiding this comment.
Remove all these _ prefixes and move it to internal package. Everything that is outside of internal should be treated as a user-exposed
shnela
force-pushed
the
jk/in-memory-stream
branch
from
fa0beac
to
97c822f
Compare
Raalsky
reviewed
Nov 4, 2022
src/neptune/internal/file_types.py
Outdated
| @@ -0,0 +1,173 @@ | |||
| # | |||
There was a problem hiding this comment.
Huh? Why inside of neptune.internal instead of neptune.new.internal?
Raalsky
previously approved these changes
Nov 4, 2022
shnela
force-pushed
the
jk/in-memory-stream
branch
from
d2dd2c3
to
6fcf1d2
Compare
Raalsky
previously approved these changes
Nov 4, 2022
Raalsky
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.