Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove get_project function #1214

Merged
merged 4 commits into from Feb 13, 2023
Merged

Conversation

AleksanderWWW
Copy link
Contributor

@AleksanderWWW AleksanderWWW commented Feb 13, 2023

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you asked the docs owner to review all the updated user-facing interfaces?

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Base: 71.36% // Head: 71.35% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (f22a276) compared to base (4c2682b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@              Coverage Diff              @@
##           dev/1.0.0    #1214      +/-   ##
=============================================
- Coverage      71.36%   71.35%   -0.01%     
=============================================
  Files            284      284              
  Lines          13656    13652       -4     
=============================================
- Hits            9745     9742       -3     
+ Misses          3911     3910       -1     
Flag Coverage Δ
unit-pull-request 71.35% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/neptune/__init__.py 100.00% <ø> (ø)
src/neptune/new/__init__.py 94.11% <ø> (ø)
src/neptune/internal/init/__init__.py 90.90% <100.00%> (ø)
src/neptune/internal/init/project.py 100.00% <100.00%> (+2.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@AleksanderWWW AleksanderWWW marked this pull request as ready for review February 13, 2023 12:13
CHANGELOG.md Outdated
@@ -3,6 +3,7 @@
### Changes
- Moved modules from `neptune.new` to `neptune` with compatibility imports and marked `neptune.new` as deprecated ([#1213](https://github.com/neptune-ai/neptune-client/pull/1213))
- Removed `neptune.*` legacy modules ([#1206](https://github.com/neptune-ai/neptune-client/pull/1206))
- Deprecated `get_project` function ([#1214](https://github.com/neptune-ai/neptune-client/pull/1214))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct me if I'm wrong, but it's deprecated already and actually removed with 1.0, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep

@AleksanderWWW AleksanderWWW changed the title deprecate get_project function Remove get_project function Feb 13, 2023
@@ -36,7 +36,6 @@
"SyncRunner",
"get_metadata_container",
"get_offline_dirs",
"get_project",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's too far. It's different function

@@ -16,7 +16,6 @@

__all__ = [
"get_metadata_container",
"get_project",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's too far. It's different function #2

@AleksanderWWW AleksanderWWW merged commit 2ad1958 into dev/1.0.0 Feb 13, 2023
@AleksanderWWW AleksanderWWW deleted the aw/deprecate_get_project branch February 13, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants