Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monitoring is off by default for interactive Python kernels #1219

Merged
merged 3 commits into from Feb 15, 2023
Merged

Monitoring is off by default for interactive Python kernels #1219

merged 3 commits into from Feb 15, 2023

Conversation

Raalsky
Copy link
Contributor

@Raalsky Raalsky commented Feb 14, 2023 •
edited

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you asked the docs owner to review all the updated user-facing interfaces?

@codecov
Copy link

codecov bot commented Feb 14, 2023 •
edited

Codecov Report

Base: 71.30% // Head: 71.34% // Increases project coverage by +0.03% 🎉

Coverage data is based on head (21f5158) compared to base (67f962d).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 21f5158 differs from pull request most recent head 1d8e441. Consider uploading reports for the commit 1d8e441 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1219      +/-   ##
==========================================
+ Coverage   71.30%   71.34%   +0.03%     
==========================================
  Files         284      284              
  Lines       13628    13643      +15     
==========================================
+ Hits         9718     9733      +15     
  Misses       3910     3910
Flag Coverage Δ
unit-pull-request 71.34% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/neptune/internal/init/run.py 89.86% <100.00%> (+0.81%) ⬆️
.../neptune/metadata_containers/metadata_container.py 88.09% <100.00%> (ø)
src/neptune/internal/init/model_version.py 98.41% <0.00%> (+0.05%) ⬆️
src/neptune/internal/init/model.py 93.84% <0.00%> (+0.19%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Raalsky
Raalsky commented Feb 14, 2023
View reviewed changes
src/neptune/metadata_containers/metadata_container.py Outdated
"Remember to stop your %s once you’ve finished logging your metadata (%s)."
" It will be stopped automatically only when the notebook"
" kernel/interactive console is terminated.",
"You're in an interactive environment, to reduce monitoring time consumption some"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@normandy7, there is nothing about such a warning in the specification so it's up to you if it should even exist 😉

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do think it could be useful to show :) Let me just tweak it a bit. I think we're shifting to the term "logging hours" instead of "monitoring time" so let's use that here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, thanks!

@Raalsky Raalsky changed the title Draft: Monitoring is off by default for interactive Python kernels Monitoring is off by default for interactive Python kernels Feb 14, 2023
Base automatically changed from dev/1.0.0 to master February 14, 2023 12:27
@Raalsky Raalsky force-pushed the rj/monitoring-off branch 2 times, most recently from 9570b65 to 591cdb5 Compare February 14, 2023 12:51
@Raalsky
Removed last_run stored in Run class (#1220)
e8ee717 
Added capture_traceback

CHANGELOG updated

Removed capture_traceback

Tests added
normandy7
normandy7 previously approved these changes Feb 14, 2023
View reviewed changes
AleksanderWWW
AleksanderWWW previously approved these changes Feb 15, 2023
View reviewed changes
@Raalsky Raalsky dismissed stale reviews from AleksanderWWW and normandy7 via 1d8e441 February 15, 2023 08:48
@Raalsky Raalsky merged commit caa1ef6 into master Feb 15, 2023
@Raalsky Raalsky deleted the rj/monitoring-off branch February 15, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleksanderWWW AleksanderWWW AleksanderWWW approved these changes

@normandy7 normandy7 normandy7 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Raalsky @normandy7 @AleksanderWWW