New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made Run
, Model
, ModelVersion
and Project
made first class citizens
#1246
Conversation
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1246 +/- ##
==========================================
- Coverage 71.51% 0.00% -71.52%
==========================================
Files 282 277 -5
Lines 13643 13583 -60
==========================================
- Hits 9757 0 -9757
- Misses 3886 13583 +9697
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
404e23e
to
09e4bc3
Compare
I didn't review the implementation, just looked at the API, and see no reason why we shouldn't have it. |
956c38a
to
a23d546
Compare
74cc437
to
47d56e5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me on the code front. Doc strings probably need to be updated, as they only point to using init_*
aliases
@normandy7, this is mostly our internal code deduplication etc. but as a result, this adds a feature to use with Run() as run:
run['a'] = 99.9
# or
run = Run() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree no docs action should be required for now. We may update the class docstrings in the future, should we decide to "officially" include the constructor approach in the API. Thanks!
This allows us to call
Run
and any other object in-place ofinit_run
:Before submitting checklist