Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added setup for neptune-client package #1263

Merged
merged 28 commits into from Feb 24, 2023
Merged

Added setup for neptune-client package #1263

merged 28 commits into from Feb 24, 2023

Conversation

Raalsky
Copy link
Contributor

@Raalsky Raalsky commented Feb 24, 2023

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you asked the docs owner to review all the updated user-facing interfaces?

@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Base: 79.48% // Head: 71.45% // Decreases project coverage by -8.04% ⚠️

Coverage data is based on head (8fc135f) compared to base (e56acd3).
Patch coverage: 70.83% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1263      +/-   ##
==========================================
- Coverage   79.48%   71.45%   -8.04%     
==========================================
  Files         281      281              
  Lines       13611    13628      +17     
==========================================
- Hits        10819     9738    -1081     
- Misses       2792     3890    +1098     
Flag Coverage Δ
e2e ?
unit ?
unit-pull-request 71.45% <70.83%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/neptune/version.py 75.00% <70.83%> (-6.82%) ⬇️
src/neptune/legacy/internal/threads/ping_thread.py 42.10% <0.00%> (-52.64%) ⬇️
...eptune/common/websockets/reconnecting_websocket.py 27.77% <0.00%> (-50.01%) ⬇️
...tune/common/websockets/websocket_client_adapter.py 34.78% <0.00%> (-50.01%) ⬇️
...neptune/legacy/internal/utils/alpha_integration.py 41.66% <0.00%> (-45.84%) ⬇️
...ternal/threads/hardware_metric_reporting_thread.py 39.13% <0.00%> (-43.48%) ⬇️
...ernal/websockets/reconnecting_websocket_factory.py 57.14% <0.00%> (-42.86%) ⬇️
...tune/legacy/internal/streams/stdstream_uploader.py 46.87% <0.00%> (-40.63%) ⬇️
src/neptune/common/patches/bravado.py 38.88% <0.00%> (-38.89%) ⬇️
...eptune/internal/backends/hosted_neptune_backend.py 42.43% <0.00%> (-35.33%) ⬇️
... and 91 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

neptune_version = check_version("neptune")
neptune_client_version = check_version("neptune-client")
if neptune_version is not None and neptune_client_version is not None:
raise RuntimeError("Corrupted state")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@normandy7 This will be called in case of both packages installed neptune and neptune-client

elif neptune_version is not None:
return neptune_version
elif neptune_client_version is not None:
warn_once("You should install `neptune`")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@normandy7 Warning about deprecated neptune-client package.

@Raalsky Raalsky requested a review from troda February 24, 2023 11:12
@Raalsky Raalsky merged commit 216bc6d into master Feb 24, 2023
@Raalsky Raalsky deleted the rj/double-package branch February 24, 2023 12:57
shnela pushed a commit that referenced this pull request Feb 28, 2023
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants