New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added setup for neptune-client package #1263
Conversation
Codecov ReportBase: 79.48% // Head: 71.45% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1263 +/- ##
==========================================
- Coverage 79.48% 71.45% -8.04%
==========================================
Files 281 281
Lines 13611 13628 +17
==========================================
- Hits 10819 9738 -1081
- Misses 2792 3890 +1098
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
src/neptune/version.py
Outdated
neptune_version = check_version("neptune") | ||
neptune_client_version = check_version("neptune-client") | ||
if neptune_version is not None and neptune_client_version is not None: | ||
raise RuntimeError("Corrupted state") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@normandy7 This will be called in case of both packages installed neptune
and neptune-client
src/neptune/version.py
Outdated
elif neptune_version is not None: | ||
return neptune_version | ||
elif neptune_client_version is not None: | ||
warn_once("You should install `neptune`") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@normandy7 Warning about deprecated neptune-client
package.
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
Before submitting checklist