Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invite users to the workspace programmatically #1333

Merged
merged 11 commits into from May 9, 2023

Conversation

AleksanderWWW
Copy link
Contributor

@AleksanderWWW AleksanderWWW commented Apr 28, 2023

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

@codecov
Copy link

codecov bot commented Apr 28, 2023

Codecov Report

Patch coverage: 82.92% and project coverage change: -0.05 ⚠️

Comparison is base (b3df4c5) 79.65% compared to head (ef9c87e) 79.61%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1333      +/-   ##
==========================================
- Coverage   79.65%   79.61%   -0.05%     
==========================================
  Files         276      276              
  Lines       13530    13571      +41     
==========================================
+ Hits        10777    10804      +27     
- Misses       2753     2767      +14     
Flag Coverage Δ
py3.7 73.01% <82.92%> (-6.13%) ⬇️
py3.9 ?
ubuntu 73.01% <82.92%> (-6.40%) ⬇️
unit 73.01% <82.92%> (-0.66%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/neptune/management/internal/api.py 88.72% <77.77%> (-1.66%) ⬇️
src/neptune/management/internal/utils.py 96.15% <87.50%> (-3.85%) ⬇️
src/neptune/management/exceptions.py 97.80% <100.00%> (+0.15%) ⬆️

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@normandy7 normandy7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the role, can the end-user pass "admin"/"member", or you need to use the enums?

src/neptune/management/internal/api.py Outdated Show resolved Hide resolved
src/neptune/management/internal/api.py Outdated Show resolved Hide resolved
src/neptune/management/internal/api.py Outdated Show resolved Hide resolved
@AleksanderWWW
Copy link
Contributor Author

For the role, can the end-user pass "admin"/"member", or you need to use the enums?

The spec wasn't clear about this, so in this design I decided that the enum will be required.
This way the code is cleaner imo and there's no need to check separately if the value passed by a user is correct

Docstrings

Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
src/neptune/management/exceptions.py Outdated Show resolved Hide resolved
src/neptune/management/exceptions.py Outdated Show resolved Hide resolved
src/neptune/management/internal/utils.py Show resolved Hide resolved
src/neptune/management/internal/api.py Outdated Show resolved Hide resolved
src/neptune/management/internal/api.py Outdated Show resolved Hide resolved
src/neptune/management/internal/api.py Show resolved Hide resolved
@AleksanderWWW AleksanderWWW merged commit 2424b91 into master May 9, 2023
3 checks passed
@AleksanderWWW AleksanderWWW deleted the aw/program-invite-workspace branch May 9, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants