Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load plug-ins in try..except block #1392

Merged
merged 7 commits into from Jul 28, 2023
Merged

load plug-ins in try..except block #1392

merged 7 commits into from Jul 28, 2023

Conversation

kshitij12345
Copy link
Contributor

@kshitij12345 kshitij12345 commented Jul 7, 2023

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

Load CLI plug-ins in try..except block to avoid a failure in loading a plug-in to crash entire CLI. Tested locally.

@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage has no change and project coverage change: -6.56% ⚠️

Comparison is base (d1f0c0e) 79.50% compared to head (3eeb232) 72.95%.

❗ Current head 3eeb232 differs from pull request most recent head be2c2e4. Consider uploading reports for the commit be2c2e4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1392      +/-   ##
==========================================
- Coverage   79.50%   72.95%   -6.56%     
==========================================
  Files         280      280              
  Lines       13866    13580     -286     
==========================================
- Hits        11024     9907    -1117     
- Misses       2842     3673     +831     
Flag Coverage Δ
e2e ?
e2e- ?
e2e-management ?
e2e-s3 ?
e2e-s3-gcs ?
e2e-standard ?
macos 72.79% <0.00%> (-6.44%) ⬇️
macos-latest ?
py3.10 ?
py3.7 72.95% <0.00%> (-6.04%) ⬇️
py3.7.16 ?
py3.8 ?
py3.9 ?
ubuntu 72.95% <0.00%> (-6.33%) ⬇️
ubuntu-latest ?
unit 72.95% <0.00%> (-0.79%) ⬇️
windows ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/neptune/cli/__main__.py 0.00% <0.00%> (ø)

... and 109 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Raalsky
Raalsky previously approved these changes Jul 10, 2023
CHANGELOG.md Show resolved Hide resolved
Raalsky
Raalsky previously approved these changes Jul 28, 2023
@Raalsky Raalsky merged commit 76dcb5e into master Jul 28, 2023
4 checks passed
@Raalsky Raalsky deleted the fix/plug-in-load-failure branch July 28, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants