cast integers outside of 32bits to float in StringifyValue #1443
Conversation
|
Refactored Integer class as well, as it caused circular imports |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1443 +/- ##
==========================================
- Coverage 79.60% 73.28% -6.32%
==========================================
Files 281 281
Lines 13976 13690 -286
==========================================
- Hits 11125 10033 -1092
- Misses 2851 3657 +806
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
Co-authored-by: Siddhant Sadangi <siddhant.sadangi@neptune.ai>
AleksanderWWW
dismissed stale reviews from SiddhantSadangi and normandy7
via
0f7ad72
| # check if it's an integer outside 32bit range and cast it to float | ||
| if isinstance(value, int) and (value > MAX_32_BIT_INT or value < MIN_32_BIT_INT): | ||
| logger.info( | ||
| "Value '%d' is outside the range of 32-bit integers ('%d' to '%d') and will be logged as float", |
There was a problem hiding this comment.
Why do we have to cast it to float if we want to stringify it anyway?
There was a problem hiding this comment.
Integers are not be stringified. This would serve like an additional functionality of stringify_unsupported - for unsupported types it will cast to string and for unsupported values (like ints outside of the range) it would cast those values to float
Before submitting checklist