Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose _state attribute with a getter method #1463

Merged
merged 6 commits into from Sep 6, 2023
Merged

expose _state attribute with a getter method #1463

merged 6 commits into from Sep 6, 2023

Conversation

AleksanderWWW
Copy link
Contributor

@AleksanderWWW AleksanderWWW commented Sep 5, 2023 •
edited

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

@AleksanderWWW AleksanderWWW marked this pull request as draft September 5, 2023 16:46
@codecov
Copy link

codecov bot commented Sep 5, 2023 •
edited

Codecov Report

Patch coverage is 100.00% of modified lines.

Files Changed Coverage
src/neptune/integrations/python_logger.py 100.00%
.../neptune/metadata_containers/metadata_container.py 100.00%

📢 Thoughts on this report? Let us know!.

@AleksanderWWW AleksanderWWW changed the title expose _state attribute via property expose _state attribute with a getter method Sep 6, 2023
@AleksanderWWW AleksanderWWW marked this pull request as ready for review September 6, 2023 07:12
@AleksanderWWW AleksanderWWW merged commit 8b6b008 into master Sep 6, 2023
4 checks passed
@AleksanderWWW AleksanderWWW deleted the aw/state-property-of-container branch September 6, 2023 10:54
jdudycz pushed a commit that referenced this pull request Sep 6, 2023
@AleksanderWWW
expose _state attribute with a getter method (#1463)
b8ad7f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Raalsky Raalsky Raalsky approved these changes

@normandy7 normandy7 normandy7 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AleksanderWWW @Raalsky @normandy7