-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for no synchronization callbacks #1478
Merged
Merged
Changes from 12 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
9b111e2
Added NeptuneObject interface and stop synchronization util
Raalsky 3c642a3
Parameters added to neptune objects
Raalsky e96eb9f
Changelog updated
Raalsky bf65d14
Fixed imports
Raalsky 9a7ceb5
add arg descriptions
normandy7 45543ba
tweak stop_synchronization_callback docstring
normandy7 887dff5
tweak callback error message
normandy7 9d1155d
tweak changelog entry
normandy7 128159d
Support for no progress callback
Raalsky 020f33a
Merge branch 'rj/async-callbacks' of github.com:neptune-ai/neptune-cl…
Raalsky f1b8afa
Added support for lag callback
Raalsky 572ee61
Auto review
Raalsky df28866
Auto review
Raalsky 4c4a2c1
Auto review 2
Raalsky 7543e37
Auto review 3
Raalsky 1df03d7
Auto review 4
Raalsky 4bcdcb2
Fixes
Raalsky d63465f
Auto review 5
Raalsky aaa20b7
Auto review 6
Raalsky 0d80cd0
Auto review 7
Raalsky b9709d9
clarify arg descrptions
normandy7 8f95267
Fixes
Raalsky a5e69ea
Merge branch 'rj/async-callbacks' of github.com:neptune-ai/neptune-cl…
Raalsky cfcdce2
Code review
Raalsky 5961f7d
Merge branch 'master' into rj/async-callbacks
Raalsky 94881c6
Code review
Raalsky 69276c8
Merge branch 'rj/async-callbacks' of github.com:neptune-ai/neptune-cl…
Raalsky File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -130,3 +130,6 @@ stream.bin | |
|
||
# zenml e2e | ||
.zen | ||
|
||
# mocks | ||
MagicMock/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we rewrite it slightly so that it's less indented?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, is it necessary to check this condition twice?
if self._should_call_no_progress_callback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is common pattern as lock acquiring is heavy operation: https://en.wikipedia.org/wiki/Double-checked_locking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done