Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce disk utilization error handler #1559

Merged
merged 10 commits into from Nov 10, 2023
Merged

Conversation

AleksanderWWW
Copy link
Contributor

@AleksanderWWW AleksanderWWW commented Nov 8, 2023

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
src/neptune/exceptions.py 82.93% <100.00%> (-0.46%) ⬇️
src/neptune/internal/utils/disk_utilization.py 100.00% <100.00%> (ø)

... and 104 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

@AleksanderWWW AleksanderWWW marked this pull request as ready for review November 9, 2023 11:22
@AleksanderWWW
Copy link
Contributor Author

@normandy7 Would need you to take a look at naming and error/warning messages 😄 Let me know if you have any questions!

src/neptune/exceptions.py Outdated Show resolved Hide resolved
src/neptune/exceptions.py Outdated Show resolved Hide resolved
src/neptune/internal/utils/disk_utilization.py Outdated Show resolved Hide resolved
@Raalsky Raalsky merged commit c1a067e into master Nov 10, 2023
4 checks passed
@Raalsky Raalsky deleted the aw/disk-usage-exception branch November 10, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants