Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docstrings moved to class-level for Neptune Objects #1580

Merged
merged 3 commits into from Dec 4, 2023

Conversation

Raalsky
Copy link
Contributor

@Raalsky Raalsky commented Dec 4, 2023

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

Copy link

codecov bot commented Dec 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0a3bad5) 79.99% compared to head (580622b) 76.45%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1580      +/-   ##
==========================================
- Coverage   79.99%   76.45%   -3.54%     
==========================================
  Files         292      292              
  Lines       14540    14540              
==========================================
- Hits        11631    11117     -514     
- Misses       2909     3423     +514     
Flag Coverage Δ
e2e-management ?
e2e-s3 ?
e2e-s3-gcs ?
e2e-standard ?
macos 73.51% <ø> (-6.23%) ⬇️
py3.7 73.80% <ø> (-5.66%) ⬇️
py3.9 ?
ubuntu 73.66% <ø> (-6.03%) ⬇️
unit 73.80% <ø> (-0.55%) ⬇️
windows 72.98% <ø> (-6.72%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Raalsky Raalsky changed the title Draft: Docstrings from init for Neptune objects Docstrings moved to class-level for Neptune Objects Dec 4, 2023
@Raalsky Raalsky merged commit 730a7cb into master Dec 4, 2023
4 checks passed
@Raalsky Raalsky deleted the rj/objects-docstrings branch December 4, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants