Use literals instead of str for Mode typing and typing-extensions added as a direct requirement
#1586
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1586 +/- ##
==========================================
- Coverage 79.92% 76.46% -3.46%
==========================================
Files 292 292
Lines 14540 14544 +4
==========================================
- Hits 11621 11121 -500
- Misses 2919 3423 +504
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Raalsky
changed the title
typing-extensions added as a direct requirement
| @@ -309,7 +311,7 @@ def __init__( | |||
| project: Optional[str] = None, | |||
| api_token: Optional[str] = None, | |||
| custom_run_id: Optional[str] = None, | |||
| mode: Optional[str] = None, | |||
| mode: Optional[Literal["async", "sync", "offline", "read-only", "debug"]] = None, | |||
There was a problem hiding this comment.
@Raalsky Can you elaborate on the removal of offline from the other places?
There was a problem hiding this comment.
It's never been supported except for Runs
There was a problem hiding this comment.
You can take a look at:
There is an exception about it. Probably we should adjust the docs as well.There was a problem hiding this comment.
Thankfully it's correct in the docs, I just had a mind glitch. (We don't explicitly say "for runs only" where offline mode is described, so it may not hurt to clarify it there.)
Summary
typing-extensionsLiteraltyping.Remember to adjust conda requirements as well after release.
Before submitting checklist