Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ascending parameter to fetch_*_table #1602

Merged
merged 5 commits into from Dec 18, 2023

Conversation

AleksanderWWW
Copy link
Contributor

@AleksanderWWW AleksanderWWW commented Dec 18, 2023

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

@AleksanderWWW AleksanderWWW changed the title Aw/ascending param Add ascending parameter to fetch_*_table Dec 18, 2023
Copy link

codecov bot commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9fba58f) 76.45% compared to head (584c7fd) 79.86%.

Additional details and impacted files
@@                   Coverage Diff                   @@
##           dev/fetch-ui-parity    #1602      +/-   ##
=======================================================
+ Coverage                76.45%   79.86%   +3.41%     
=======================================================
  Files                      292      292              
  Lines                    14590    14593       +3     
=======================================================
+ Hits                     11155    11655     +500     
+ Misses                    3435     2938     -497     
Flag Coverage Δ
e2e 71.43% <100.00%> (+12.81%) ⬆️
e2e- ?
e2e-management 56.23% <100.00%> (?)
e2e-s3 55.73% <0.00%> (?)
e2e-s3-gcs 55.73% <0.00%> (?)
e2e-standard 71.24% <100.00%> (?)
macos 79.67% <100.00%> (+6.13%) ⬆️
macos-latest ?
py3.10 71.39% <100.00%> (+14.40%) ⬆️
py3.7 79.44% <100.00%> (+5.61%) ⬆️
py3.7.16 70.63% <100.00%> (+15.66%) ⬆️
py3.8 ?
ubuntu 79.66% <100.00%> (+5.98%) ⬆️
ubuntu-latest ?
unit 73.83% <100.00%> (+<0.01%) ⬆️
windows 79.64% <100.00%> (+6.63%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AleksanderWWW
Copy link
Contributor Author

@AleksanderWWW AleksanderWWW merged commit e48d154 into dev/fetch-ui-parity Dec 18, 2023
29 checks passed
@AleksanderWWW AleksanderWWW deleted the aw/ascending-param branch December 18, 2023 18:52
Raalsky pushed a commit that referenced this pull request Jan 22, 2024
Raalsky pushed a commit that referenced this pull request Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants