Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete legacy package #1685

Merged
merged 7 commits into from Mar 12, 2024
Merged

Delete legacy package #1685

merged 7 commits into from Mar 12, 2024

Conversation

AleksanderWWW
Copy link
Contributor

@AleksanderWWW AleksanderWWW commented Mar 12, 2024

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 73.01%. Comparing base (218d6e7) to head (1c0aeec).

Files Patch % Lines
...tune/common/websockets/websocket_client_adapter.py 50.00% 1 Missing ⚠️
src/neptune/integrations/utils.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           dev/2.0    #1685      +/-   ##
===========================================
- Coverage    76.94%   73.01%   -3.94%     
===========================================
  Files          304      304              
  Lines        15501    15470      -31     
===========================================
- Hits         11927    11295     -632     
- Misses        3574     4175     +601     
Flag Coverage Δ
macos 76.81% <60.00%> (+2.76%) ⬆️
py3.7 76.97% <60.00%> (+2.35%) ⬆️
ubuntu 76.83% <60.00%> (+2.15%) ⬆️
unit 76.97% <60.00%> (+2.35%) ⬆️
windows 75.49% <60.00%> (+1.95%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Raalsky
Copy link
Contributor

Raalsky commented Mar 12, 2024

There should be some entries about legacy client support in codecov.yml as well.

@@ -81,16 +81,10 @@ component_management:
- src/neptune/logging/**
- src/neptune/metadata_containers/**
- src/neptune/new/**
- src/netpune/types/**
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Raalsky how did this even work? 😆

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh. Good catch!

@AleksanderWWW AleksanderWWW merged commit 8d80095 into dev/2.0 Mar 12, 2024
4 checks passed
@AleksanderWWW AleksanderWWW deleted the aw/remove-legacy branch March 12, 2024 14:40
Raalsky pushed a commit that referenced this pull request Mar 13, 2024
Raalsky pushed a commit that referenced this pull request Mar 14, 2024
Raalsky pushed a commit that referenced this pull request Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants