Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove deprecation warnings in fetch_runs_table() #1686

Merged
merged 2 commits into from Mar 12, 2024

Conversation

szysad
Copy link
Contributor

@szysad szysad commented Mar 12, 2024

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

@szysad szysad requested a review from normandy7 March 12, 2024 10:03
@szysad szysad marked this pull request as ready for review March 12, 2024 10:03
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.79%. Comparing base (0d3be5c) to head (ddee6f1).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1686      +/-   ##
==========================================
- Coverage   80.83%   74.79%   -6.04%     
==========================================
  Files         304      304              
  Lines       15501    15182     -319     
==========================================
- Hits        12530    11356    -1174     
- Misses       2971     3826     +855     
Flag Coverage Δ
e2e ?
e2e-management ?
e2e-s3 ?
e2e-s3-gcs ?
e2e-standard ?
macos 74.64% <ø> (-5.92%) ⬇️
py3.10 ?
py3.7 74.91% <ø> (-5.42%) ⬇️
py3.7.16 ?
py3.8 ?
py3.9 ?
ubuntu 74.77% <ø> (-5.90%) ⬇️
unit 74.91% <ø> (-0.51%) ⬇️
windows 73.82% <ø> (-6.50%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szysad szysad merged commit 219432c into master Mar 12, 2024
4 checks passed
@szysad szysad deleted the ss/fetch-tables-remove-deprecation branch March 12, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants