Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable fetch_last and download_last #1731

Merged
merged 4 commits into from Apr 16, 2024
Merged

Conversation

szysad
Copy link
Contributor

@szysad szysad commented Apr 10, 2024

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

@szysad
Copy link
Contributor Author

szysad commented Apr 10, 2024

E2E

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 73.07%. Comparing base (db6e9f8) to head (95936af).

Files Patch % Lines
src/neptune/attributes/series/file_series.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1731      +/-   ##
==========================================
- Coverage   75.26%   73.07%   -2.19%     
==========================================
  Files         243      243              
  Lines       12950    12766     -184     
==========================================
- Hits         9747     9329     -418     
- Misses       3203     3437     +234     
Flag Coverage Δ
e2e ?
e2e-management ?
e2e-s3 ?
e2e-s3-gcs ?
py3.10 ?
py3.11 ?
py3.12 ?
py3.7 73.07% <80.00%> (-1.54%) ⬇️
py3.8 ?
py3.9 ?
ubuntu 73.02% <80.00%> (-2.19%) ⬇️
unit 73.07% <80.00%> (-0.74%) ⬇️
windows 71.96% <80.00%> (-2.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szysad szysad marked this pull request as ready for review April 10, 2024 12:58
Raalsky
Raalsky previously approved these changes Apr 12, 2024
@szysad szysad force-pushed the ss/disable-fetch-download-last branch from 9e1c3e0 to 95936af Compare April 16, 2024 09:11
@szysad szysad merged commit f5e087c into master Apr 16, 2024
4 checks passed
@szysad szysad deleted the ss/disable-fetch-download-last branch April 16, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants