Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endpoints added for enchanced fields search #1751

Merged
merged 6 commits into from Apr 19, 2024
Merged

Conversation

Raalsky
Copy link
Contributor

@Raalsky Raalsky commented Apr 17, 2024

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 78.40909% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 71.97%. Comparing base (352b1ad) to head (83024ec).

Files Patch % Lines
...eptune/internal/backends/hosted_neptune_backend.py 17.64% 14 Missing ⚠️
.../neptune/internal/backends/neptune_backend_mock.py 50.00% 2 Missing ⚠️
...ptune/internal/backends/offline_neptune_backend.py 60.00% 2 Missing ⚠️
src/neptune/api/models.py 97.43% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1751      +/-   ##
==========================================
- Coverage   75.14%   71.97%   -3.18%     
==========================================
  Files         245      246       +1     
  Lines       13050    12933     -117     
==========================================
- Hits         9806     9308     -498     
- Misses       3244     3625     +381     
Flag Coverage Δ
e2e ?
e2e-management ?
e2e-s3 ?
e2e-s3-gcs ?
e2e-standard ?
macos 71.92% <78.40%> (-3.11%) ⬇️
py3.10 ?
py3.11 ?
py3.12 ?
py3.7 71.97% <78.40%> (-2.49%) ⬇️
py3.7.16 ?
py3.8 ?
py3.9 ?
ubuntu 71.92% <78.40%> (-3.16%) ⬇️
unit 71.97% <78.40%> (-0.69%) ⬇️
windows 70.67% <78.40%> (-3.00%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Raalsky Raalsky changed the title Draft: Endpoints added for enchanced entries search Endpoints added for enchanced fields search Apr 18, 2024


class Paginatable(Protocol):
def __call__(self, *, next_page: Optional[NextPage] = None, **kwargs: Any) -> Any: ...
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there is an assumption that a Paginatable will always return an Iterator of some kind, we could make the type hint more precise. Is that correct, or we cannot guarantee that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was my initial try but I was struggling with it. You cannot create a Protocol with Generic at the same time and you have to provide a type var as an input if you would like to have something as an output. You can give it a try if you want.

@Raalsky Raalsky merged commit 24a49f2 into master Apr 19, 2024
4 checks passed
@Raalsky Raalsky deleted the rj/enhanced-entries-search branch April 19, 2024 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants