New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Endpoints added for enchanced fields search #1751
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1751 +/- ##
==========================================
- Coverage 75.14% 71.97% -3.18%
==========================================
Files 245 246 +1
Lines 13050 12933 -117
==========================================
- Hits 9806 9308 -498
- Misses 3244 3625 +381
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d95ef8e
to
3de6113
Compare
|
||
|
||
class Paginatable(Protocol): | ||
def __call__(self, *, next_page: Optional[NextPage] = None, **kwargs: Any) -> Any: ... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If there is an assumption that a Paginatable
will always return an Iterator
of some kind, we could make the type hint more precise. Is that correct, or we cannot guarantee that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was my initial try but I was struggling with it. You cannot create a Protocol
with Generic
at the same time and you have to provide a type var as an input if you would like to have something as an output. You can give it a try if you want.
Before submitting checklist