Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove gitpython dependency #1752

Merged
merged 3 commits into from
May 7, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@
- Added initial operations to the `core.operations` package ([#1759](https://github.com/neptune-ai/neptune-client/pull/1759))
- Move some `OperationProcessor` implementations to `neptune.core.operation_processors` ([#1760](https://github.com/neptune-ai/neptune-client/pull/1760))
- Changed handling of too long custom run id ([#1761](https://github.com/neptune-ai/neptune-client/pull/1761))
- Skip tests that require `GitPython` when not installed ([#1752](https://github.com/neptune-ai/neptune-client/pull/1752))

### Fixes
- Fixed `tqdm.notebook` import only in Notebook environment ([#1716](https://github.com/neptune-ai/neptune-client/pull/1716))
Expand Down
1 change: 0 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ swagger-spec-validator = ">=2.7.4"
protobuf = "^4.0.0"

# Built-in integrations
GitPython = ">=2.0.8"
psutil = "*"
pandas = "*"

Expand Down
4 changes: 2 additions & 2 deletions tests/e2e/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@

import pytest
from faker import Faker
from git import Repo

from neptune import init_project
from neptune.internal.utils.s3 import get_boto_s3_client
Expand Down Expand Up @@ -135,7 +134,8 @@ def project(environment):


@pytest.fixture(scope="session")
def repo(tmp_path_factory) -> Repo:
def repo(tmp_path_factory) -> "Repo": # noqa: F821
Repo = pytest.importorskip("git.Repo")
path = tmp_path_factory.mktemp("git_repo")
repo = Repo.init(path)
file = path / f"{uuid.uuid4()}.txt"
Expand Down
5 changes: 3 additions & 2 deletions tests/unit/neptune/new/internal/utils/test_git.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@
#
import datetime

import git
import pytest
from git import Repo
from mock import (
MagicMock,
patch,
Expand All @@ -36,6 +34,9 @@
)
from neptune.types import GitRef

git = pytest.importorskip("git")
Repo = pytest.importorskip("git.Repo")


@pytest.mark.skip("Temporarily disabled - will be brought back in 2.0.0")
class TestGit:
Expand Down