Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial operations #1759

Merged
merged 6 commits into from May 6, 2024
Merged

Add initial operations #1759

merged 6 commits into from May 6, 2024

Conversation

AleksanderWWW
Copy link
Contributor

@AleksanderWWW AleksanderWWW commented Apr 30, 2024

Before submitting checklist

  • Did you update the CHANGELOG? (not for test updates, internal changes/refactors or CI/CD setup)
  • Did you ask the docs owner to review all the user-facing changes?

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 76.02740% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 72.73%. Comparing base (f1cffff) to head (7adedfa).
Report is 1 commits behind head on master.

Files Patch % Lines
src/neptune/core/operations/operation_visitor.py 0.00% 26 Missing ⚠️
src/neptune/core/operations/operation.py 92.37% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1759      +/-   ##
==========================================
- Coverage   75.19%   72.73%   -2.46%     
==========================================
  Files         246      249       +3     
  Lines       13153    13296     +143     
==========================================
- Hits         9890     9671     -219     
- Misses       3263     3625     +362     
Flag Coverage Δ
e2e ?
e2e-management ?
e2e-s3 ?
e2e-s3-gcs ?
e2e-standard ?
macos 72.56% <76.02%> (-2.54%) ⬇️
py3.10 ?
py3.11 ?
py3.12 ?
py3.7 72.01% <76.02%> (-2.43%) ⬇️
py3.8 72.56% <76.02%> (-2.54%) ⬇️
py3.9 ?
ubuntu 71.97% <76.02%> (-3.17%) ⬇️
unit 72.73% <76.02%> (+0.01%) ⬆️
windows 70.73% <76.02%> (-3.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AleksanderWWW AleksanderWWW marked this pull request as ready for review May 6, 2024 08:37
szysad
szysad previously approved these changes May 6, 2024
Copy link
Contributor

@szysad szysad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one!

def clean(self, operation_storage: OperationStorage) -> None:
pass

def to_dict(self) -> dict:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use dict[str, Any] typing instead?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

src/neptune/core/operations/operation.py Outdated Show resolved Hide resolved
src/neptune/core/operations/operation.py Outdated Show resolved Hide resolved
Copy link
Contributor

@szysad szysad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@szysad szysad merged commit c5b1741 into master May 6, 2024
4 checks passed
@szysad szysad deleted the aw/add-initial-operations branch May 6, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants