Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed url building in Windows #672

Merged
merged 4 commits into from
Aug 25, 2021
Merged

Fixed url building in Windows #672

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a9aecc8
Fixed url building
Raalsky Aug 25, 2021
0dc71cd
CHANGELOG updated
Raalsky Aug 25, 2021
42ab9bb
CHANGELOG updated
Raalsky Aug 25, 2021
d3425de
Linter
Raalsky Aug 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## neptune-client 0.10.7 [UNRELEASED]

### Fixes
- Fixed url building in Windows ([#672](https://github.com/neptune-ai/neptune-client/pull/672))

## neptune-client 0.10.6

### Fixes
Expand Down
15 changes: 2 additions & 13 deletions neptune/new/internal/backends/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,9 @@
import socket
import sys
import time
import pathlib
from typing import Optional, Dict

from urllib.parse import urlparse, urlunparse
from urllib.parse import urlparse, urljoin

import click
import requests
Expand Down Expand Up @@ -155,14 +154,4 @@ def build_operation_url(base_api: str, operation_url: str) -> str:
if '://' not in base_api:
base_api = f'https://{base_api}'

base_api_url = urlparse(base_api)
path = pathlib.Path(base_api_url.path) / operation_url

return urlunparse((
base_api_url.scheme,
base_api_url.netloc,
str(path),
base_api_url.params,
base_api_url.query,
base_api_url.fragment,
))
return urljoin(base=base_api, url=operation_url)