Sync only offline runs #894
Conversation
There was a problem hiding this comment.
Github doesn't allow me to comment on non-updated lines, so I'll write it here:
I think you can replace
offline_dirs = get_offline_dirs(base_path)
self.sync_offline_runs(base_path, project_name, offline_dirs)
in sync_all_containers (ref. https://github.com/neptune-ai/neptune-client/pull/894/files#diff-4d1af3d92b849386a88c5ace8eef8d8f3c60c30caaf857de8a174692ce5e1441R257-R258) with a call to sync_all_offline_containers to avoid code duplication.
Apart from that lgtm.
|
Thank you @pkasprzyk! It is done ✅ |
|
@Blaizzy one more thing: could you add changelog entry? |
|
Sure I'll do it 👍🏽 |
|
@pkasprzyk I've updated the changelog for the next release. |
1 similar comment
|
@pkasprzyk I've updated the changelog for the next release. |
CHANGELOG.md
Outdated
| @@ -1,3 +1,8 @@ | |||
| ## neptune-client 0.16.2 | |||
There was a problem hiding this comment.
One more thing (I haven't mentioned that before, sorry):
When you create a new version entry in CHANGELOG, please mark it with [UNRELEASED], so everyone can tell at a glance that they can add new entries to it. Admittedly we don't ALWAYS do that, but at least try ;). Example: https://github.com/neptune-ai/neptune-client/pull/825/files
|
Thanks! I have made the changes ✅ |
* add sync all offline containers arg and logic * add method to sync all offline containers * text formatting * add offline-only arg docstring * remove default false * adding default value back * remove email policy * remove metavar * add exception for use of object_names and offline * black format * refactor sync_all_containers * Update changelog for upcoming release * add unreleased tag
No description provided.