Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Sabine <sabine.nyholm@neptune.ai>
  • Loading branch information
kshitij12345 and normandy7 committed Jun 20, 2023
1 parent ea0d14b commit be06ca3
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
# Neptune - Tensorboard integration
# Neptune-TensorBoard integration

See [the official docs](https://docs.neptune.ai/integrations/tensorboard/).
6 changes: 3 additions & 3 deletions src/neptune_tensorboard/integration/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,8 @@ def check_tf_version():
except AttributeError:
# user facing
message = (
f"Unrecognized tensorflow version: {version}. Please make sure "
"that the tensorflow version is >={MIN_TF_VERSION}"
f"Unrecognized TensorFlow version: {version}. Please make sure "
"that the TensorFlow version is >={MIN_TF_VERSION}"
)
raise Exception(message)

Expand Down Expand Up @@ -117,7 +117,7 @@ def check_tensorboardx_version():

# user facing
FRAMEWORK_NOT_FOUND_WARNING_MSG = (
"neptune-tensorboard: Tensorflow or PyTorch or tensorboardX was not found, ",
"neptune-tensorboard: TensorFlow or PyTorch or tensorboardX was not found, ",
"please ensure that it is available.",
)

Expand Down
4 changes: 2 additions & 2 deletions src/neptune_tensorboard/sync/sync_impl.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
import tbparse
except ModuleNotFoundError:
# user facing
raise ModuleNotFoundError("neptune-tensorboard: require `tbparse` for exporting logs (pip install tbparse)")
raise ModuleNotFoundError("neptune-tensorboard: tbparse is required for exporting logs. Install it with: pip install tbparse")


def compute_md5_hash(path):
Expand Down Expand Up @@ -71,7 +71,7 @@ def _export_to_neptune_run(self, path):

if self._experiment_exists(hash_run_id, self._project):
# user facing
click.echo(f"{path} was already synced")
click.echo(f"{path} was already synchronized")
return

with neptune.init_run(custom_run_id=hash_run_id, project=self._project, api_token=self._api_token) as run:
Expand Down

0 comments on commit be06ca3

Please sign in to comment.