fix(Target): replace target type with isExternal

neptune-mutual-blue · Apr 19, 2023 · 24a94a6 · 24a94a6
1 parent 2ddcbc2
commit 24a94a6
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/src/components/DetailedListView.astro b/src/components/DetailedListView.astro
@@ -9,7 +9,6 @@ interface Props {
   subtitle: string;
   items: DetailedListViewItem[];
   showArrow?: boolean;
-  target?: string;
 }
 
 const { props } = Astro;
@@ -29,7 +28,7 @@ const { props } = Astro;
     {
       props.items.map((item) => {
         return (
-          <a class="list item" href={normalizeUrl(item.href)} target={item.target} rel={item.target ? "noreferrer" : undefined}>
+          <a class="list item" href={normalizeUrl(item.href)} target={item.isExternal ? "_blank" : undefined} rel={item.isExternal ? "noreferrer" : undefined}>
             <div class="title and intro">
               <div class="title with badge">
                 <h3 class="title">{item.title}</h3>

diff --git a/src/data/tools.ts b/src/data/tools.ts
@@ -50,7 +50,7 @@ const tools: Web3ToolItem[] = [
     category: 'IPFS Gateway',
     icon: 'code-square-01',
     badges: [],
-    target: '_blank'
+    isExternal: true
   }
 ]
 

diff --git a/src/views/Web3Tools.astro b/src/views/Web3Tools.astro
@@ -21,7 +21,7 @@ const items = tools.map((tool) => {
     category: tool.category,
     icon: tool.icon,
     href: tool.path || `/web3-tools/${tool.slug}/`,
-    target: tool.target,
+    isExternal: tool.isExternal,
   };
 });
 ---

diff --git a/types/custom.d.ts b/types/custom.d.ts
@@ -94,7 +94,7 @@ interface DetailedListViewItem {
   href: string
   icon: string
   category: string
-  target?: string
+  isExternal?: boolean
 }
 
 interface NamedIcon {
@@ -229,7 +229,7 @@ interface Web3ToolItem {
     icon: string
     text: string
   }>
-  target?: '_blank' | '_self' | '_parent' | '_top'
+  isExternal?: boolean
 }
 
 interface TableRenderConfig<T> {