feat(404 Page, Empty State): Implement 404 page and empty state in marketplace #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acharyarupak391
approved these changes
Apr 17, 2023
| @@ -35,7 +35,7 @@ const BaseLayout = ({ children, videos }) => { | |||
| <Header headerStyle={router.pathname === '/marketplace' ? 'colored' : null} videos={videos} /> | |||
| <div className='header gap' /> | |||
| {children} | |||
| <Footer /> | |||
| {router.pathname !== '/404' && <Footer />} | |||
There was a problem hiding this comment.
Why footer is not there is 404 route?
@flashburst Sharad says it wasn't there in design.
flashburst
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes