Merge pull request #228 from neptune-mutual-blue/improvements

Improvements
neptune-mutual-blue · Mar 6, 2024 · 1256dfc · 1256dfc
2 parents 8db6480 + 2ff33d4
commit 1256dfc
Show file tree

Hide file tree

Showing 13 changed files with 1,946 additions and 2,112 deletions.
diff --git a/.env.sample b/.env.sample
@@ -3,4 +3,8 @@ POLYGONSCAN_API_KEY=
 ETHERSCAN_API_KEY=
 ALCHEMY_API_URL=
 ROPSTEN_RPC_URL=
-KOVAN_RPC_URL=
+KOVAN_RPC_URL=
+ETHEREUM_RPC_URL=
+ARBITRUM_RPC_URL=
+BSC_RPC_URL=
+NPM_IPFS_API_URL=
diff --git a/.github/CONTRIBUTING b/.github/CONTRIBUTING
@@ -0,0 +1,34 @@
+## Installation
+
+### Checklist
+
+- [ ] Install [foundry](https://book.getfoundry.sh/getting-started/installation)
+- [ ] Install [lcov](https://formulae.brew.sh/formula/lcov) on Mac OS or [genhtml](https://manpages.ubuntu.com/manpages/xenial/man1/genhtml.1.html) on Linux
+
+```
+git submodule update --init --recursive
+forge install
+yarn install
+```
+
+### Commands
+
+**Build**
+
+```
+yarn build
+```
+
+**Test**
+
+```
+yarn test
+```
+
+**Coverage**
+
+```
+yarn coverage
+
+open ./coverage/index.html
+```
diff --git a/contracts/fakes/FakeStore.sol b/contracts/fakes/FakeStore.sol
@@ -71,7 +71,10 @@ contract FakeStore is IStore {
   function setBool(bytes32 k, bool v) external override {
     if (v) {
       boolStorage[k] = v;
+      return;
     }
+
+    delete boolStorage[k];
   }
 
   function setInt(bytes32 k, int256 v) external override {

diff --git a/hardhat.config.js b/hardhat.config.js
@@ -47,7 +47,7 @@ const config = {
       explorer: 'https://testnet.bscscan.com/'
     },
     polygonMumbai: {
-      url: 'https://rpc-mumbai.maticvigil.com	',
+      url: 'https://rpc-mumbai.maticvigil.com',
       chainId: 80001,
       accounts: [process.env.PRIVATE_KEY],
       gasPrice: 2 * GWEI,

diff --git a/oracle/package.json b/oracle/package.json
@@ -43,15 +43,15 @@
     "dotenv": "^10.0.0",
     "ethereum-waffle": "^3.4.0",
     "ethers": "^5.5.2",
-    "hardhat": "^2.8.0",
-    "hardhat-contract-sizer": "^2.1.1",
-    "hardhat-gas-reporter": "^1.0.6",
+    "hardhat": "2.19.3",
+    "hardhat-contract-sizer": "2.1.1",
+    "hardhat-gas-reporter": "1.0.6",
     "openzeppelin-solidity": "3.4.0",
-    "solidity-coverage": "^0.7.17",
+    "solidity-coverage": "^0.8.7",
     "standard": "^16.0.4"
   },
   "volta": {
-    "node": "16.13.1",
+    "node": "18.12.0",
     "yarn": "1.22.19"
   }
 }