Governance Refactor and Bug Fixes #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `accrueInterest` function to be called during unlock cycle - Update protocol initialization function to be called more than once - Refactored `addContract` function to restrict replacing an existing contract - Fixed bug in `getReporter` function - Fixed bug in `getResolutionInfoFor` function - Added zero value checks on `Processor`, `cxToken`, `cxTokenFactory`, `Reporter`, `Finalization`, `Resolvable`, `Unstakable`, `CoverBase`, `CoverProvision`, `CoverReassurance`, `CoverStake`, `LiquidityEngine`, `VaultBase`, `WithFlashLoan`, `Policy`, `PolicyAdmin`, `StoreBase`, `BaseLibV1`, `StakingPoolLibV1`, and more. - Created `events.md` file - Dropped redundant function `Finalized` from `ICxToken` - Dropped redundant function `PriceUpdated` from `IPriceDiscovery` - Refactored namespaces to keen into account both active and historical cover statuses. Functions refactored and added `getCoverStatusOf`, `getStatusOf`, `getCoverStatusKey`, `getCoverStatusOfKey`, - Fixed slither and NPM analyzer issues - Refactored unit tests - Refactored deployment script, composer, and utils - Updated ABIs - Updated documentation - Updated keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
accrueInterestfunction to be called during unlock cycleaddContractfunction to restrict replacing an existing contractgetReporterfunctiongetResolutionInfoForfunctionProcessor,cxToken,cxTokenFactory,Reporter,Finalization,Resolvable,Unstakable,CoverBase,CoverProvision,CoverReassurance,CoverStake,LiquidityEngine,VaultBase,WithFlashLoan,Policy,PolicyAdmin,StoreBase,BaseLibV1,StakingPoolLibV1, and more.events.mdfileFinalizedfromICxTokenPriceUpdatedfromIPriceDiscoverygetCoverStatusOf,getStatusOf,getCoverStatusKey,getCoverStatusOfKey,