Liquidity, Lending Period, and Withdrawal Window #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Because of block gas limit, exploded the `addCover` function to `addCover` and `deployVault`. - New events added: `VaultDeployed` - Fixed a bug `getCoverFeeInfoInternal` which caused revert exceptions because of zero values due to precision loss (uint division) - For brevity, rearranged input arguments in `_getCoverFeeRate` - Refactored and renamed `getCoverableInternal` to `getStablecoinBalanceOfCoverPoolInternal` - Fixed mistake in `getPriceInternal` - Added check `mustBeDuringWithdrawalPeriod` in RoutineInvokerLibV1 - Fixed a bug in `withdrawRewardsInternal` of `StakingPoolLib` now sending correct fee to the treasury address - Added a new check `mustHaveStoppedCoverStatus` in ValidationLibV1 - Fixed bug of `calculateLiquidityInternal` - Refactored `getInfoInternal` of `VaultLibV1`. - Dropped events: `MinLiquidityPeriodSet` - Dropped obsolete function `addLiquidityInternalOnly` from the Vault contract - Refactored Vault's `getInfo` function; deleted lockup period and added withdrawal open and close dates. - For brevity, renamed Policy contract's `getCoverable` to `getAvailableLiquidity` - Dropped obsolete `minLiquidityPeriod` configuration constant from protocol initialization function - Refactored ClaimsProcessor's `setClaimPeriod` function to also accept cover keys. If a cover key is not specified, it sets the default/fallback claim period. - Added coverKey to `ClaimPeriodSet` event. #subgraph #frontend - Added a warning note in `_finalize` logic to NOT RESET staking information - Updated `_resolve` function to get claim period by cover key. In other words, each cover now has its own claim period. - Added `unstakeWithClaim` to IUnstakable - Refactored `unstakeWithClaim` in Unstakable to be an override - Refactored, added, and rearranged `addCover` input arguments. Dropped: initialLiquidity. Added: floor, ceiling, claimPeriod. - Fixed bug in `addCover` which now checks the NPM input against minimum cover creation stake instead of minium first reporting stake. - Fixed a bug info `getUnstakeInfoFor`. Now returns 0 as reward if called after finalization. - Refactored `IUniswapV2RouterLike` - Updated Fakes: `FakeUniswapV2RouterLike` - Refactored unit tests - Refactored deployment script, composer, and utils - Updated ABIs - Updated documentation - Updated keys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addCoverfunction toaddCoveranddeployVault.VaultDeployedgetCoverFeeInfoInternalwhich caused revert exceptions because of zero values due to precision loss (uint division)_getCoverFeeRategetCoverableInternaltogetStablecoinBalanceOfCoverPoolInternalgetPriceInternalmustBeDuringWithdrawalPeriodin RoutineInvokerLibV1withdrawRewardsInternalofStakingPoolLibnow sending correct fee to the treasury addressmustHaveStoppedCoverStatusin ValidationLibV1calculateLiquidityInternalgetInfoInternalofVaultLibV1.MinLiquidityPeriodSetaddLiquidityInternalOnlyfrom the Vault contractgetInfofunction; deleted lockup period and added withdrawal open and close dates.getCoverabletogetAvailableLiquidityminLiquidityPeriodconfiguration constant from protocol initialization functionsetClaimPeriodfunction to also accept cover keys. If a cover key is not specified, it sets the default/fallback claim period.ClaimPeriodSetevent. #subgraph #frontend_finalizelogic to NOT RESET staking information_resolvefunction to get claim period by cover key. In other words, each cover now has its own claim period.unstakeWithClaimto IUnstakableunstakeWithClaimin Unstakable to be an overrideaddCoverinput arguments. Dropped: initialLiquidity. Added: floor, ceiling, claimPeriod.addCoverwhich now checks the NPM input against minimum cover creation stake instead of minium first reporting stake.getUnstakeInfoFor. Now returns 0 as reward if called after finalization.IUniswapV2RouterLikeFakeUniswapV2RouterLike@notes
Subgraph:
Frontend: