Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes for new files coming from google in the latest zip #44

Merged
merged 6 commits into from
Feb 20, 2021

Conversation

rrishabh
Copy link
Contributor

No description provided.

Copy link
Collaborator

@stephenyeargin stephenyeargin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good. Not a blocker, but could we add test coverage for the new models and attributes as part of this PR? The examples in the ./spec folder are fairly rudimentary to implement. Can be run using rake test.

gtfs.gemspec Outdated
@@ -1,4 +1,5 @@
# -*- encoding: utf-8 -*-
require "date"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
require "date"

This is no longer required after #42.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the PR

@stephenyeargin stephenyeargin merged commit 7233930 into nerdEd:master Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants