Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create advanced and global options #371

Merged
merged 1 commit into from Mar 13, 2018
Merged

Create advanced and global options #371

merged 1 commit into from Mar 13, 2018

Conversation

LilliJane
Copy link
Contributor

@LilliJane LilliJane commented Mar 13, 2018 •
edited

Closes #354

--kube-config and --timeout are now part of the global options. And when we create a command, we can now provide some additional options that will appear under the Advanced options section

@LilliJane LilliJane mentioned this pull request Mar 13, 2018
Closed
advanderveer
advanderveer approved these changes Mar 13, 2018
View reviewed changes
Copy link
Contributor

@advanderveer advanderveer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also LGTM!

@LilliJane LilliJane merged commit bac1d43 into master Mar 13, 2018
@LilliJane LilliJane deleted the fix/options branch March 13, 2018 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@advanderveer advanderveer advanderveer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LilliJane @advanderveer