Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to use private images #384

Merged
merged 9 commits into from
Mar 23, 2018
Merged

Add option to use private images #384

merged 9 commits into from
Mar 23, 2018

Conversation

LilliJane
Copy link
Contributor

@LilliJane LilliJane commented Mar 21, 2018

This pull request will close #378.

  • Add --private option that will ask the user for their username and their password.
  • Label the secrets with registry, project and image names.
  • Extract image registry from the provided image name (e.g quay.io/repo/image to quay.io, repo/image to index.docker.io).
  • Use environment variables as username and password for the secret
  • List secrets before creating a new one to search for a secret matching with the current image
  • Tests secret creation
  • Tests secret listing
  • index.docker.io
  • quay.io
  • --clean-creds flag
  • gcr.io
  • aws
  • azurecr
  • other registries (?)

Edge case:
If users make a typo in their username/password and the cli automatically reuse a secret, users won't be able to modify their secret which will lead jobs to fail. This is why people can use the --clean-creds flag with the nerd job run command to be asked again for their credentials.

@LilliJane LilliJane requested a review from advdv March 21, 2018 15:48
@LilliJane LilliJane changed the title [WIP] Add option to use private images Add option to use private images Mar 23, 2018
@advdv advdv merged commit a7e9147 into master Mar 23, 2018
@advdv advdv deleted the feature/private-images branch March 23, 2018 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow users to run private images
2 participants