Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add timeout and feedback during login #426

Merged
merged 2 commits into from
Jul 4, 2018
Merged

Add timeout and feedback during login #426

merged 2 commits into from
Jul 4, 2018

Conversation

LilliJane
Copy link
Contributor

@LilliJane LilliJane requested a review from advdv June 19, 2018 14:38
@LilliJane LilliJane changed the title add timeout and feedback during login Add timeout and feedback during login Jun 19, 2018
@LilliJane LilliJane requested a review from dxlbnl June 19, 2018 14:53
@LilliJane
Copy link
Contributor Author

@neoel I added you as a reviewer so you can give me your feedback on the statement I added. (Were you expecting more feedback? different feedback?)

advdv
advdv approved these changes Jun 21, 2018
View reviewed changes
Copy link
Contributor

@advdv advdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, could you make sure that the error on timeout is human friendly?

@LilliJane
Copy link
Contributor Author

@advanderveer I added some more error handling, could you review it, please?

@advdv advdv merged commit 09e2833 into master Jul 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@advdv advdv advdv approved these changes

@dxlbnl dxlbnl Awaiting requested review from dxlbnl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LilliJane @advdv