Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update zingolib to latest dev #139

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Update zingolib to latest dev #139

merged 1 commit into from
Nov 12, 2023

Conversation

AArnott
Copy link
Collaborator

@AArnott AArnott commented Nov 12, 2023

✨ This pull request encompasses a series of significant updates and improvements to the codebase, as detailed in the commit history. The key highlights include:

  1. Integration Testing and Bug Fixes:

    • A new integration test was added to ensure the stability and functionality of the save buffer (d21c6d7f).
    • The do_delete function was modified to ensure proper compilation on mobile platforms (dfb77458).
    • A major fix was implemented in the add_save_buffer_to_lightclient to revamp save handles and enhance overall performance (56697419).
  2. Code Optimization and Cleanup:

    • Unnecessary println statements were removed to clean up the code (34d1babd).
    • Modifications were made to mark unconfirmed_spent more accurately

zingolib diff

Copy link

codecov bot commented Nov 12, 2023

Codecov Report

Merging #139 (8df0b42) into main (0a18ddf) will increase coverage by 0.01%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
+ Coverage   75.95%   75.97%   +0.01%     
==========================================
  Files         148      148              
  Lines        8964     8968       +4     
  Branches      810      810              
==========================================
+ Hits         6809     6813       +4     
  Misses       1956     1956              
  Partials      199      199              
Flag Coverage Δ
LinuxHost 75.97% <ø> (+0.01%) ⬆️
Release 75.97% <ø> (+0.01%) ⬆️
WindowsHost 75.97% <ø> (+0.01%) ⬆️
macOSHost 75.97% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@AArnott AArnott merged commit 64c1a90 into main Nov 12, 2023
6 checks passed
@AArnott AArnott deleted the updateZingo branch November 12, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant