Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move control over min. req'd confirmations to the managed code #149

Merged
merged 1 commit into from
Nov 19, 2023

Conversation

AArnott
Copy link
Collaborator

@AArnott AArnott commented Nov 19, 2023

No description provided.

Copy link

codecov bot commented Nov 19, 2023

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (20fe2d4) 76.13% compared to head (7d197ad) 76.08%.

Files Patch % Lines
src/Nerdbank.Zcash/RustBindings/LightWallet.cs 0.00% 22 Missing ⚠️
src/Nerdbank.Zcash/LightWalletClient.cs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #149      +/-   ##
==========================================
- Coverage   76.13%   76.08%   -0.06%     
==========================================
  Files         150      150              
  Lines        8860     8866       +6     
  Branches      810      810              
==========================================
  Hits         6746     6746              
- Misses       1915     1921       +6     
  Partials      199      199              
Flag Coverage Δ
LinuxHost 76.08% <0.00%> (-0.06%) ⬇️
Release 76.08% <0.00%> (-0.06%) ⬇️
WindowsHost 76.08% <0.00%> (-0.06%) ⬇️
macOSHost 76.08% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AArnott AArnott merged commit 547c6a3 into main Nov 19, 2023
4 of 6 checks passed
@AArnott AArnott deleted the minConfirmations branch November 19, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant