Fix fee calculation, and simplify 'fairy dust' to just 'dust' #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It led to a negative balance shown to the user when the wallet had no funds in it. It also included fees for notes that were not yet mature, contrary to its documentation.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #157 +/- ##
=======================================
Coverage 75.57% 75.57%
=======================================
Files 150 150
Lines 8926 8926
Branches 811 811
=======================================
Hits 6746 6746
Misses 1981 1981
Partials 199 199
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AArnott
added a commit
to nerdcash/zingolib
that referenced
this pull request
Nov 23, 2023
This is a port from the functionality originally added to Nerdbank.Zcash in [this change](nerdcash/Nerdbank.Cryptocurrencies#150) and subsequently fixed in [this change](nerdcash/Nerdbank.Cryptocurrencies#157).
AArnott
added a commit
to nerdcash/zingolib
that referenced
this pull request
Nov 23, 2023
This is a port from the functionality originally added to Nerdbank.Zcash in [this change](nerdcash/Nerdbank.Cryptocurrencies#150) and subsequently fixed in [this change](nerdcash/Nerdbank.Cryptocurrencies#157).
AArnott
added a commit
to nerdcash/zingolib
that referenced
this pull request
Nov 23, 2023
This is a port from the functionality originally added to Nerdbank.Zcash in [this change](nerdcash/Nerdbank.Cryptocurrencies#150) and subsequently fixed in [this change](nerdcash/Nerdbank.Cryptocurrencies#157).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.