Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bytes instead of sequence<u8> in UDL #171

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Use bytes instead of sequence<u8> in UDL #171

merged 1 commit into from
Nov 27, 2023

Conversation

AArnott
Copy link
Collaborator

@AArnott AArnott commented Nov 27, 2023

No description provided.

@AArnott AArnott marked this pull request as ready for review November 27, 2023 15:39
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Attention: 111 lines in your changes are missing coverage. Please review.

Comparison is base (4a17bdc) 75.16% compared to head (e789980) 75.33%.
Report is 3 commits behind head on main.

Files Patch % Lines
src/Nerdbank.Zcash/RustBindings/LightWallet.cs 0.00% 109 Missing ⚠️
src/Nerdbank.Zcash/LightWalletClient.cs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #171      +/-   ##
==========================================
+ Coverage   75.16%   75.33%   +0.16%     
==========================================
  Files         155      155              
  Lines        9016     8999      -17     
  Branches      829      828       -1     
==========================================
+ Hits         6777     6779       +2     
+ Misses       2039     2019      -20     
- Partials      200      201       +1     
Flag Coverage Δ
LinuxHost 75.33% <0.00%> (+0.16%) ⬆️
Release 75.33% <0.00%> (+0.16%) ⬆️
WindowsHost 75.33% <0.00%> (+0.16%) ⬆️
macOSHost 75.33% <0.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AArnott AArnott merged commit 07e07e2 into main Nov 27, 2023
5 of 6 checks passed
@AArnott AArnott deleted the uniffi_bytes branch November 27, 2023 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant