Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functions to test orchard/sapling receiver for ownership by an account #37

Merged
merged 2 commits into from
Jul 9, 2023

Conversation

AArnott
Copy link
Collaborator

@AArnott AArnott commented Jul 9, 2023

No description provided.

@AArnott AArnott added the enhancement New feature or request label Jul 9, 2023
@AArnott AArnott changed the title Add functions to test orchard receiver ownership Add functions to test orchard/sapling receiver for ownership by a spending key Jul 9, 2023
@AArnott AArnott changed the title Add functions to test orchard/sapling receiver for ownership by a spending key Add functions to test orchard/sapling receiver for ownership by an account Jul 9, 2023
@AArnott AArnott enabled auto-merge July 9, 2023 00:25
@codecov-commenter
Copy link

codecov-commenter commented Jul 9, 2023

Codecov Report

Merging #37 (891a62d) into main (dcc1d9b) will decrease coverage by 0.32%.
The diff coverage is 81.17%.

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   95.34%   95.03%   -0.32%     
==========================================
  Files          86       90       +4     
  Lines        3720     3804      +84     
==========================================
+ Hits         3547     3615      +68     
- Misses        173      189      +16     
Flag Coverage Δ
LinuxHost 95.03% <81.17%> (-0.32%) ⬇️
Release 95.03% <81.17%> (-0.32%) ⬇️
WindowsHost 95.03% <81.17%> (-0.32%) ⬇️
macOSHost 95.03% <81.17%> (-0.32%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Nerdbank.Zcash/DiversifierKey.cs 100.00% <ø> (ø)
src/Nerdbank.Zcash/Orchard/IncomingViewingKey.cs 0.00% <0.00%> (ø)
test/Nerdbank.Zcash.Tests/Zip32HDWalletTests.cs 100.00% <ø> (ø)
src/Nerdbank.Zcash/NativeMethods.cs 84.21% <85.00%> (+0.42%) ⬆️
src/Nerdbank.Zcash/Orchard/FullViewingKey.cs 75.67% <88.23%> (+10.67%) ⬆️
...dbank.Zcash/Sapling/DiversifiableFullViewingKey.cs 92.30% <92.85%> (+0.30%) ⬆️
...erdbank.Zcash.Tests/Orchard/FullViewingKeyTests.cs 100.00% <100.00%> (ø)
....Tests/Sapling/DiversifiableFullViewingKeyTests.cs 100.00% <100.00%> (ø)
test/Nerdbank.Zcash.Tests/TestBase.cs 100.00% <100.00%> (ø)

@AArnott AArnott merged commit 66a3e07 into main Jul 9, 2023
4 checks passed
@AArnott AArnott deleted the checkDiversifiedAddrOwnership branch July 9, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants