Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BIP-32 and BIP-44 support #5

Merged
merged 20 commits into from
May 7, 2023
Merged

Add BIP-32 and BIP-44 support #5

merged 20 commits into from
May 7, 2023

Conversation

AArnott
Copy link
Collaborator

@AArnott AArnott commented May 7, 2023

  • BIP-32 HD wallet key derivations
  • BIP-44 formalized pattern for key path derivations

@AArnott AArnott added the enhancement New feature or request label May 7, 2023
@AArnott AArnott marked this pull request as ready for review May 7, 2023 20:40
@codecov-commenter
Copy link

codecov-commenter commented May 7, 2023

Codecov Report

Merging #5 (4f11696) into main (cfc3eab) will decrease coverage by 0.13%.
The diff coverage is 93.91%.

@@            Coverage Diff             @@
##             main       #5      +/-   ##
==========================================
- Coverage   96.39%   96.27%   -0.13%     
==========================================
  Files          41       58      +17     
  Lines        2412     3218     +806     
==========================================
+ Hits         2325     3098     +773     
- Misses         87      120      +33     
Flag Coverage Δ
LinuxHost 96.27% <93.91%> (-0.13%) ⬇️
Release 96.27% <93.91%> (-0.13%) ⬇️
WindowsHost 96.27% <93.91%> (-0.13%) ⬇️
macOSHost 96.27% <93.91%> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Nerdbank.Cryptocurrencies/Base58Check.cs 100.00% <ø> (ø)
src/Nerdbank.Cryptocurrencies/BitUtilities.cs 35.71% <32.07%> (-64.29%) ⬇️
....Cryptocurrencies/Bip32HDWallet.ExtendedKeyBase.cs 92.39% <92.39%> (ø)
...c/Nerdbank.Cryptocurrencies/Bip44MultiAccountHD.cs 93.33% <93.33%> (ø)
...ryptocurrencies/Bip32HDWallet.ExtendedPublicKey.cs 93.61% <93.61%> (ø)
...yptocurrencies/Bip32HDWallet.ExtendedPrivateKey.cs 93.75% <93.75%> (ø)
src/Nerdbank.Cryptocurrencies/Bech32.cs 95.10% <100.00%> (ø)
...Nerdbank.Cryptocurrencies/Bip32HDWallet.KeyPath.cs 100.00% <100.00%> (ø)
...dbank.Cryptocurrencies/Bip32HDWallet.PrivateKey.cs 100.00% <100.00%> (ø)
...rdbank.Cryptocurrencies/Bip32HDWallet.PublicKey.cs 100.00% <100.00%> (ø)
... and 13 more

@AArnott AArnott merged commit 3d96fab into main May 7, 2023
3 checks passed
@AArnott AArnott deleted the bip32 branch May 7, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants