Improve promString performance #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kgeckhart
changed the title
|
Awesome thanks a lot! |
|
Hey @thomaspeitz , happy new year! 🎉 Any chance you can look again at this PR during the week? This has been running in production for a while now and proved useful! |
|
Sorry for the long delay was doing some vacation. Hope to release it on Thuersday :) |
|
Thanks @thomaspeitz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When profiling a large scrape for CPU + Memory, creating this replacer + compiling the regex stood out a lot due to the number of calls to
promString. Moving them to package level should help improve this.