Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix targetgroup arn lookup #529 #530

Merged

Conversation

domcyrus
Copy link
Contributor

This provides a way to retain the metric name arn and tags if at least one dimension filter matches. The current implementation is always using the last dimension lookup whatever that might be. This change does retain the metrics if it already matched previously.

With this change you can fix #529 using the following config:

"discovery":
  "jobs":
  - "enableMetricData": true
    "metrics":
    - "length": 3600
      "name": "ProcessedBytes"
      "period": 300
      "statistics":
      - "Sum"
    "regions":
    - "eu-west-1"
    "type": "alb"
  - "enableMetricData": true
    "metrics":
    - "length": 300
      "name": "HealthyHostCount"
      "period": 300
      "statistics":
      - "Minimum"
    - "length": 300
      "name": "UnHealthyHostCount"
      "period": 300
      "statistics":
      - "Maximum"
    searchTags:
      - key: Port
        value: .*
    "regions":
    - "eu-west-1"
    "type": "alb"

Note using the alb type twice. We use it with the tag we expect to be present on the targetgroup ARN.

@thomaspeitz thomaspeitz merged commit 1884b9a into nerdswords:master Mar 26, 2022
@thomaspeitz
Copy link
Contributor

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] alb, nlb targetgroup metrics not joinable on name with aws_(alb,nlb)_info metric
2 participants