Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metric yace_cloudwatch_getmetricdata_metrics_total #939

Merged
merged 2 commits into from
Feb 15, 2024

Conversation

keyolk
Copy link
Contributor

@keyolk keyolk commented May 15, 2023

#339

I saw the issue above but seems that the conclusion is incorrect.
GetMetricData of CloudWatch API costs by the number of its returned metrics.

So it would be worth having how much data is fetched via GetMetricData.

Signed-off-by: gavin.jeong <gavin.jeong@sendbird.com>
@keyolk keyolk changed the title Add metric yace_cloudwatch_getmetricdata_retrieved_total Add metric yace_cloudwatch_getmetricdata_metrics_total Jul 12, 2023
@ecktom
Copy link

ecktom commented Nov 3, 2023

Is there something missing here? Would be nice to get this merged as currently, there is no way to properly track costs

@jaseemabid
Copy link

+1 to this feature.

The description in the README.md to track costs is wrong, which we can fix after landing this PR. I'm happy to test and update the docs myself.

@cristiangreco cristiangreco merged commit b7fffd8 into nerdswords:master Feb 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants