Skip to content
This repository has been archived by the owner on Feb 16, 2019. It is now read-only.

Feature request: add support for "gtfo" #7

Open
kereyroper opened this issue Aug 12, 2016 · 4 comments
Open

Feature request: add support for "gtfo" #7

kereyroper opened this issue Aug 12, 2016 · 4 comments

Comments

@kereyroper
Copy link

An owner may notice that a contributor has opened a PR that will result in immediate issues if merged. This is common when unit tests provide an insufficient level of validation, or if there are logical conflicts between the version of the theoretical merge against which Travis or another CI system has run unit tests, and the version which will result from multiple merges being actually performed that do not manifest as code-level merge conflicts.

github-lgtm should support adding a comment, perhaps "gtfo," which would disallow merging of the PR until the issue has been corrected.

@octobeard
Copy link

I could see this being very useful. Especially appreciate the suggested comment syntax.

@chase-seibert
Copy link
Contributor

Good suggestion.

@jemiahlee
Copy link
Contributor

Alternate syntax suggestion: 🙅

@octobeard
Copy link

why_not_both-

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants