Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add list command for shell script purpose, also add check in add habit to avoid duplicates on name #33

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Add list command for shell script purpose, also add check in add habit to avoid duplicates on name #33

merged 2 commits into from
Jul 23, 2020

Conversation

yoms
Copy link

@yoms yoms commented Jul 21, 2020 •
edited

Usage dijo -l for printing the habit names list

ps: Its my first commit in rust...

@yoms yoms changed the title Add list command for shell script purpose Add list command for shell script purpose, also add check in add habit to avoid duplicates on name Jul 21, 2020
@yoms yoms force-pushed the master branch 2 times, most recently from 14fd788 to 5ea7568 Compare July 21, 2020 22:35
@yoms
Add list command for shell script purpose
9dfe454 
Usage dijo -l for printing the habit names list

Add check on habit add to avoid duplicate habits
@nerdypepper
Copy link
Owner

Its my first commit in rust...

I am really happy to see people using dijo's codebase as a place to start out learning!

nerdypepper
nerdypepper requested changes Jul 22, 2020
View reviewed changes
Copy link
Owner

@nerdypepper nerdypepper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here are a couple of changes you could include in this PR:

src/app/impl_self.rs Outdated Show resolved Hide resolved
src/app/impl_self.rs Show resolved Hide resolved
src/main.rs Show resolved Hide resolved
@nerdypepper nerdypepper added the enhancement New feature or request label Jul 23, 2020
@nerdypepper nerdypepper mentioned this pull request Jul 23, 2020
Closed
@nerdypepper nerdypepper merged commit 537e4f5 into nerdypepper:master Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nerdypepper nerdypepper nerdypepper requested changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yoms @nerdypepper