fix get_tile_bin_edges; revert ndc2pix (#113)

nerfstudio-project · Feb 1, 2024 · e13eff4 · e13eff4
1 parent 0f71be8
commit e13eff4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/gsplat/cuda/csrc/forward.cu b/gsplat/cuda/csrc/forward.cu
@@ -151,8 +151,9 @@ __global__ void get_tile_bin_edges(
             tile_bins[cur_tile_idx].x = 0;
         if (idx == num_intersects - 1)
             tile_bins[cur_tile_idx].y = num_intersects;
-        return;
     }
+    if (idx == 0)
+        return;
     int32_t prev_tile_idx = (int32_t)(isect_ids_sorted[idx - 1] >> 32);
     if (prev_tile_idx != cur_tile_idx) {
         tile_bins[prev_tile_idx].y = idx;

diff --git a/gsplat/cuda/csrc/helpers.cuh b/gsplat/cuda/csrc/helpers.cuh
@@ -5,7 +5,7 @@
 #include <iostream>
 
 inline __device__ float ndc2pix(const float x, const float W, const float cx) {
-    return 0.5f * W * x + cx + 0.5f;
+    return 0.5f * W * x + cx - 0.5f;
 }
 
 inline __device__ void get_bbox(