Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix train_mlp_nerf and save the model at the end of training #177

Merged

Conversation

97littleleaf11
Copy link
Contributor

@97littleleaf11 97littleleaf11 commented Mar 20, 2023

The near and far parameter of render_image during evaluation is not consistent with training stage. Currently this is not a real problem since there is a default near and far value in ray_marching for unbound scenes.

Other modifications:

  • reuse the MIPNERF360_UNBOUNDED_SCENES and NERF_SYNTHETIC_SCENES.
  • save the model at the end of the training. Since it still takes some time for MLP to converge, it would be annoying for first-time user who forgot to generate results.

@liruilong940607 liruilong940607 merged commit 9a1c0ab into nerfstudio-project:master Mar 27, 2023
@liruilong940607
Copy link
Collaborator

Thanks for the cleanup!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants