Standardize the sample format to CSR sparse tensor. #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed traversal with far_plane * test added for traversal with near and far planes * More correct test * black formatting for test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently realize that the current way of using the
packed_infoto represent sparse samples along rays, is very similar to the standard CSR sparse matrix formula, but not entirely the same. And various toolboxes either already or on the way to support this formula with operations, including:So it would be great to switch to the standard CSR formula in this repo as well, to benefit from the existing and future supports in the PyTorch community.
For example, the conversion between
packed_infoandray_indiceswere required some CUDA programming, but with CSR formula it is already supported bytorch_scatter.segment_csrandtorch_scatter.gather_csr.Also, hopefully it will be less difficult for users to get hands on using this repo, when it comes to understanding how batched data is packed. Following the CSR standard there would be tones of tutorial / docs users can refer to, and for users that are already familiar with CSR sparse matrix there will be zero learning curve.
However, this would inevitably leads to some API changes, which we want to minimize as we go.
This PR is to start a trial on the migration and see how it goes.