Skip to content

Commit

Permalink
Patch spiral rendering w/ parallel datamanager (#2637)
Browse files Browse the repository at this point in the history
* fix jittering in markdown in viewer beta

* Revert "fix jittering in markdown in viewer beta"

This reverts commit 70ade42.

* print correctly formatted url in banner for viewer beta

* allow parallel datamanager in spiral rendering

* lint

* Update render.py

---------

Co-authored-by: Brent Yi <yibrenth@gmail.com>
  • Loading branch information
kerrj and brentyi committed Nov 30, 2023
1 parent c8c5552 commit 8b85c44
Showing 1 changed file with 12 additions and 1 deletion.
13 changes: 12 additions & 1 deletion nerfstudio/scripts/render.py
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@
VanillaDataManager,
VanillaDataManagerConfig,
)
from nerfstudio.data.datamanagers.parallel_datamanager import ParallelDataManager
from nerfstudio.data.datamanagers.random_cameras_datamanager import (
RandomCamerasDataManager,
)
from nerfstudio.data.datasets.base_dataset import Dataset
from nerfstudio.data.scene_box import OrientedBox
from nerfstudio.data.utils.dataloaders import FixedIndicesEvalDataloader
Expand Down Expand Up @@ -666,7 +670,14 @@ def main(self) -> None:

install_checks.check_ffmpeg_installed()

assert isinstance(pipeline.datamanager, VanillaDataManager)
assert isinstance(
pipeline.datamanager,
(
VanillaDataManager,
ParallelDataManager,
RandomCamerasDataManager,
),
)
steps = int(self.frame_rate * self.seconds)
camera_start = pipeline.datamanager.eval_dataloader.get_camera(image_idx=0).flatten()
camera_path = get_spiral_path(camera_start, steps=steps, radius=self.radius)
Expand Down

0 comments on commit 8b85c44

Please sign in to comment.