generalize mask collation to other image-like data #1959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A little more context - This change was added to make it easier to incorporate additional image-like auxiliary data (e.g. depth, semantic maps, etc.). Rather than looking for special keys (currently only "mask"), just assume any data with the same dimensions as the image should be treated like "mask" is currently. I think another option would be to have a way to somehow "register" image-like data keys, but this seemed like a less disruptive change. Please let me know if there is an existing way to go about this that I'm missing. |
tancik
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Variable resolution image collation currently looks for the special keys "image" and "mask" only.
This change is a generalization that looks for "image", and then treats any other keys with the same first two dimensions as "image" as auxiliary data to be collated accordingly.