Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update installation docs #1970

Merged
merged 3 commits into from
May 23, 2023
Merged

Update installation docs #1970

merged 3 commits into from
May 23, 2023

Conversation

tancik
Copy link
Contributor

@tancik tancik commented May 22, 2023

No description provided.

machenmusik
machenmusik requested changes May 22, 2023
View reviewed changes
Copy link
Contributor

@machenmusik machenmusik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions, but the main difference is how to set the environment variable if using Windows Command Prompt. It may be better to have a tabset for Linux and Windows

docs/quickstart/installation.md Outdated Show resolved Hide resolved
docs/quickstart/installation.md Show resolved Hide resolved
docs/quickstart/installation.md Outdated Show resolved Hide resolved
docs/quickstart/installation.md Show resolved Hide resolved
@tancik tancik requested a review from machenmusik May 22, 2023 17:05
machenmusik
machenmusik approved these changes May 22, 2023
View reviewed changes
Copy link
Contributor

@machenmusik machenmusik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only thing I would say is that we are inconsistent about tiny-cuda-nn, TinyCUDA, etc. in the docs

@tancik tancik merged commit a906020 into main May 23, 2023
4 checks passed
@tancik tancik deleted the tancik/update_tcnn_docs branch May 23, 2023 00:39
@tancik tancik restored the tancik/update_tcnn_docs branch May 23, 2023 00:41
@SauravMaheshkar SauravMaheshkar deleted the tancik/update_tcnn_docs branch May 24, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@machenmusik machenmusik machenmusik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tancik @machenmusik