[WIP] Fix model loading collate_fn non-static #1990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, Im able to load checkpoints. Train for 2k iters Load checkpoint |
jkulhanek
changed the title
|
Do you mean loading of checkpoints trained previously to #1944 (specifically)? At some past point / date? |
|
I believe the error happens when you load pre 0.3.0 checkpoint in >=0.3.0 nerfstudio. |
|
Yes, you can reproduce the error if you remove the collate_fn field manually from config.json: |
|
What I suggested here is also not good. I don't think collate_fn gets registered as a field now. |
|
Do you think it is worth fixing? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After fixing typing errors #1944 I believe there as a bug introduced which prevents trained checkpoints to be loaded.
Similar issue here:
pydantic/pydantic#1596
Can anyone please confirm that loading of trained checkpoints is broken and this PR fixes it?